bvaughn/react-devtools-experimental

Profiling doesn't work in Firefox

bvaughn opened this issue · 8 comments

Profiling doesn't work in Firefox

@bvaughn it seems that Safari as well

@finico There's no Safari extension. Are you referring to the alpha release of the standalone DevTools? Because profiling works for Safari for me using that version.

@bvaughn I've tried at https://react-devtools-experimental.now.sh
Profiler shows commits but they're empty (without graph)

Ah, gotcha. Thanks for clarifying.

I guess it's not really important for Safari to support the test shell. Really that's just meant as a convenience tool for local development. I assume the underlying cause is probably the same though, so fixing the Firefox (extension) should also fix the Safari demo page 😄

Looks like profiling is working for me on the Firefox extension, using the latest release.

The Safari issue isn't related to the Profiler. Looks like the AutoSizer isn't expanding to fill the parent container for some reason. (The height is 0 so the data just doesn't show up.) This nags me a bit, but since Safari isn't an officially targeted browser it's also not a huge concern.

Reload and profile seems busted in Firefox :( not sure why

Fixed 2f1c100