bvaughn/react-devtools-experimental

Don't show "context" for classes without either contextType or contextTypes

gaearon opened this issue · 9 comments

gaearon commented
  • Don't show "context" for classes without either contextType or contextTypes
  • For classes with contextTypes, change the label to "legacy context" instead
hristo-kanchev commented

I'll take over this one 👍

bvaughn commented

Please hold off for now. Im in the process of merging this repo into the main React repo (facebook/react#16381) and it might be tricky to import PRs that come in while this is in progress. 😄

Thanks for the offer, and we'll be happy to accept the contribution once the migration is done.

  • 👍1
hristo-kanchev commented

Sure thing. 👍

gaearon commented

You can still start work and send a PR, but you'll have to re-submit it to a proper place later.

bvaughn commented

Merging might also be tricky, as a bunch of files are being moved around. Just thought it would be easier to wait a couple of days 😄

gaearon commented

I don't mean it would be on you to merge :-)

I'm thinking @hristo-kanchev can do the work and send a PR. Then we can ask him to copy paste the specific files he touched, find their new places in React repo, and send a PR there. That shouldn't involve putting more work on your plate.

  • 👍1
bvaughn commented

Nah, I didn't take it that way. I just wanted to safe Hristo the hassle of merging 😄

  • 👍2
hristo-kanchev commented

Nice idea @gaearon . I'll prepare the code and get it ready for submission once we merge DevTools in the main react repo.

bvaughn commented

This repository is being merged into the main React repo (github.com/facebook/react). As part of this, I am moving all issues to that repository as well and closing them here.

This issue has been relocated to:
facebook/react#16466