Why yield test_triple in validation_data method?
ZichaoHuang opened this issue · 1 comments
ZichaoHuang commented
I think the validation_data
method should yields self.__valid_triple
, but in ProjE_softmax.py it yields self.__test_triple
, why?
bxshi commented
Good catch! I think that is a mistake... Thanks for pointing it out! Feel free to make a PR our I'll correct it later :)