bycycle-tools/bycycle

Conda install version `1.0.0` not compatible with `BycycleGroup` tutorials

ntolley opened this issue · 3 comments

ntolley commented

Just came across the issue that some of the tutorials are not compatible 1.0.0 release distributed on the conda repository. Specifically it looks like the BycycleGroup class wasn't added until 1.1.0 so it throws an import error. pip install works fine of course!

ryanhammonds commented

I merged this PR that may have fixed the issue? I don't use conda but lmk if it doesn't fix the install.

  • 🎉1
ntolley commented

Yeah that updated the version! Can confirm the import passes after testing locally.

Also related to the same tutorial, it seems like there's a variable that doesn't get used here

I can try revising it in a PR if you guys are are cool with it! I'm guessing it should be something like:

compute_kwargs = {'burst_method': 'cycles', 'thresholds': thresholds}
bg_rest = BycycleGroup(**compute_kwargs)

?

ryanhammonds commented

@ntolley I can review a PR for this if you want to make one. Thanks!