bytecodealliance/jco

`src/cmd/transpile.js` tests for `false` instead of a falsy value

Closed this issue · 1 comments

BrianJDrake commented

jco/src/cmd/transpile.js

Line 92 in c47e492

if (opts.wasiShim !== false) {

This code tests specifically for false, whereas most JS developers would probably expect it to test for a falsy value.

Related issue: What should the default value be? Changing it to false is one option for #183.

guybedford commented

An explicit false value is the only way to opt-out here, so the validation is correct.