[PyTorch 2.2.2-1.5.11-SNAPSHOT] Exception java.lang.UnsatisfiedLinkError: no jnitorch in java.library.path on WIndows

Question

[PyTorch 2.2.2-1.5.11-SNAPSHOT] Exception java.lang.UnsatisfiedLinkError: no jnitorch in java.library.path on WIndows

haifengl opened this issue 7 months ago · 15 comments

The same code works fine with 2.2.1-1.5.11-SNAPSHOT.

Answer 1 · 2024-05-13T04:27:47.000Z

Which platform?

Answer 2 · 2024-05-13T14:27:01.000Z

It doesn't work on Windows 10. It works on Ubuntu 22.04 and macOS 13/14. It doesn't work on older macOS though (e.g. macOS 11). It is fine to drop the support of older macOS.

Answer 3 · 2024-05-15T08:25:06.000Z

Could you check what the Dependencies tool says is missing?
https://github.com/bytedeco/javacpp-presets/wiki/Debugging-UnsatisfiedLinkError-on-Windows

Answer 4 · 2024-05-15T14:03:58.000Z

c10, asmjit, and libomp140 are missing on Windows 10.

Answer 5 · 2024-05-15T14:21:43.000Z

On macOS 11, it cannot load macosx-x86_64/libjnitorch.dylib. However, the libjnitorch.dylib file does exist.

Caused by: java.lang.UnsatisfiedLinkError: Can't load library: /Users/xyz/.javacpp/cache/pytorch-2.2.2-1.5.11-20240502.145852-21-macosx-x86_64.jar/org/bytedeco/pytorch/macosx-x86_64/libjnitorch.dylib

Answer 6 · 2024-05-15T14:28:38.000Z

@haifengl @sbrunk Could you please test the builds on Windows and Mac?

Answer 7 · 2024-05-15T14:30:09.000Z

BTW, macOS 11 is no longer supported by either Apple or GitHub, so please upgrade to at least macOS 12

Answer 8 · 2024-05-15T18:47:31.000Z

It is okay to drop supporting macOS 11. Does PyTorch 2.2.2-1.5.11-SNAPSHOT support macOS on arm64 yet?

Answer 9 · 2024-05-18T11:43:09.000Z

I run a test on a windows 10 VM with 2.2.2 and it works, but jnitorch.dll is indeed linked with libomp140.x86_64.dll that is found in my \windows\system32. It probably came with VS or another software.

I guess we should include an OpenMP library in the jar. I'm seeing that the official libtorch archive includes the Intel version.

@saudet, what's the best way to do this ? the Pytorch CMakeList.txt doesn't use InstallRequiredSystemLibraries

Answer 10 · 2024-05-18T13:20:38.000Z

That's apparently a file that comes with Visual Studio, so we should add it to this preload list here:
https://github.com/bytedeco/javacpp/blob/master/src/main/java/org/bytedeco/javacpp/presets/javacpp.java#L42

Answer 11 · 2024-05-18T13:27:47.000Z

Ok.
Openmp is not used by many presets. Shouldn't we add it to the preload list of presets needing it only ?

Answer 12 · 2024-05-18T13:29:15.000Z

No, please don't do that

Answer 13 · 2024-05-18T13:43:17.000Z

Ok, would you like a PR for this or can you add it directly ?

Answer 14 · 2024-05-18T13:51:03.000Z

Yes, pull requests always welcome :) Thanks

Answer 15 · 2024-05-20T03:01:50.000Z

Thanks. It runs on Windows now. However, it doesn't produce good models on Windows though. I will create a new ticket about it.