0B_readsector GPIO47 High Event Interrupt Enabled

Line 257 in e2bcbff

r=*GPHEN1; r|=1<<15; *GPHEN1=r;

This is enabling the GPIO High Detect Enable for GPIO 47 (activity led I think). Is there a reason for this? Without enabling interrupts or an interrupt handler or anything it just doesn't make sense.

Huh, that was a long time ago... I must admit I don't remember all the bits. Enabling the activity LED should not cause any harm even if it's not blinking in lack of interrupts. Could be unnecessary, however if it works this way, then I rather not change the code.

I encourage you to test it with and without that bit set to see if there's any difference at all.

Nice catch, btw!
bzt

Huh, that was a long time ago... I must admit I don't remember all the bits. Enabling the activity LED should not cause any harm even if it's not blinking in lack of interrupts. Could be unnecessary, however if it works this way, then I rather not change the code.

I encourage you to test it with and without that bit set to see if there's any difference at all.

Nice catch, btw!
bzt

If you intended to blink the activity led then you should be using GPCLR1 to disable and GPSET1 to enable it. What the code there is doing is enabling the High Event Interrupt. If someone were to use the 0B_readsector example for an sd card driver like https://github.com/boochow/micropython-raspberrypi then if they try to use irq 52, the interrupt which triggers for all gpio pins, they will encounter the interrupt always being triggered.

GPCLR1 is missing from you gpio.h This would be the correct definition. #define GPCLR1 ((volatile unsigned int*)(MMIO_BASE+0x0020002C))

This should be reopened.