c-cube/ocaml-trace

Depend on `trace` instead of `trace.core` leads to module resolution failure

ELLIOTTCABLE opened this issue · 1 comments

ELLIOTTCABLE commented

Installing trace.0.2 from opam, and adding it to the dune deps:

------ dune 100644
++++++ dune 100644
@|-51,33 +51,35 ============================================================
 |  xmlm
 |  zip
+|  trace
 |  opentelemetry
 |  opentelemetry-client-ocurl)
 | (preprocess
 |  (per_module
 |   ((action
 |     (run camlp4o %{input-file}))

… then referring to Trace.Collector.S, results in a compile-error:

File "trace_collector.ml", line 58, characters 17-34:
58 |   let module M : Trace.Collector.S = struct
                      ^^^^^^^^^^^^^^^^^
Error: The module Trace.Collector is an alias for module Trace_core__.Collector, which is missing

Did something fail to get properly copied/exposed in the v0.2 refactor?

Apologies if it turns out this is something specific to our architecture. 😅

c-cube commented
  • ❤️1