Update instructions to create a custom build of aframe 1.5.0

Question

Update instructions to create a custom build of aframe 1.5.0

vincentfretin opened this issue 8 months ago · 6 comments

Update the instructions to create a custom build of aframe 1.5.0/master with hubs patches required to make MOZ_lightmap and reflection probe working. So instead of super-three 147, apply the patches to super-three 161.

Answer 1 · 2024-03-12T18:02:00.000Z

With aframe 1.5.0/three 161, there is a texture issue with uv probably. The fix to do is probably similar to the one we did in AdaRoseCannon/aframe-xr-boilerplate#22

Answer 2 · 2024-03-17T18:23:51.000Z

Also encoding = THREE.sRGBEncoding will need to be replaced by colorSpace = THREE.SRGBColorSpace; in src/components/environment-settings.js and src/components/gltf-model-plus.js

Answer 3 · 2024-04-22T11:32:42.000Z

With aframe 1.5.0/three 161, there is a texture issue with uv probably. The fix to do is probably similar to the one we did in AdaRoseCannon/aframe-xr-boilerplate#22

In my fork I did this: Elettrotecnica@ab21c27

The best would be to have it configurable somewhere, but probably most hubs models assume this anyway.

Answer 4 · 2024-04-22T14:19:12.000Z

Thanks @Elettrotecnica! Yeah I don't think we need to make it configurable here, it's used only with MOZ_lightmap node this way.

Answer 5 · 2024-04-24T07:43:30.000Z

If you want @Elettrotecnica you can create a PR with your commit, you can remove the TODO in the comment.
Setting channel won't do anything on aframe 1.4.2 so I can merge. I'll create an aframe master build with hubs patches later.

Answer 6 · 2024-04-24T07:49:57.000Z

Actually I'm ok with all your changes in your fork, so you can just create a big PR when you're done with your changes and I'll merge.