Problems with instructions
nofiv opened this issue · 4 comments
The latest version of binlex v1.1.1 outputs some seemingly incorrect instruction traits. Tested on an OpenSSL library (SHA1:ef406228f7694359c5f87e2ee7b4f760dcf160f6). Command binlex -m pe:x86_64 --instructions -i <lib_name> | jq -r 'select(.type == ("instruction")) | .trait' returns a number of weird traits such as 00 00, 00 ff, ??
Did you check to see if the instructions are also attributed with the invalid_instructions value greater than zero?
Ops, I kind of missed that attribute. ?? is incorrect, however 00 00, 00 ff are correct. There are some long sequences of instructions with 00 00 - ~100 of them
Having a quick look here capstone is not signifying to us that these instructions are invalid.
As such this is an issue that should likely be taken upstream to the capstone repo if it is one.
Closing for now 😄