Entropy uses map to store frequncies, a vector should be used

Question

Entropy uses map to store frequncies, a vector should be used

rpkrawczyk opened this issue 3 years ago · 2 comments

in float Common::Entropy(string trait) a map<char,int> is used to store frequencies. Every access via operator[] is logarithmic in the size of the container which would result in a slower runtime.

Answer 1 · 2022-04-27T19:44:34.000Z

Use vector, remember to skip zero frequency elements.

Answer 2 · 2022-04-27T21:01:41.000Z

Fixed, and in milestone branch now thanks to @emgon !