caas-team/sparrow

Code smell: no error returned in any controller function

puffitos opened this issue · 0 comments

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

During #37 I noticed that the ChecksController doesn't ever return an error in any of its functions, as they are all throttled down the error channel.

When the err is always nil, then it should not be part of the function's signature :)

Expected Behavior

No error as a return parameter.

Steps To Reproduce

No response

Relevant logs and/or screenshots, environment information, etc.

No response

Who can address the issue?

Everyone

Anything else?

No response