cadenzah/videojs-react-enhanced

Let user import css instead

ScottEAdams opened this issue · 1 comments

Is your feature request related to a problem? Please describe.

I was hoping to test this out on nextjs but sadly it throws the error:

./node_modules/video.js/dist/video-js.css
Global CSS cannot be imported from within node_modules.
Read more: https://err.sh/next.js/css-npm
Location: node_modules/videojs-react-enhanced/dist/index.es.js

Describe the solution you'd like

In nextjs any global css must be loaded in _app.js so removing the video-js.css import would let me do so.

Thank you for reporting an issue for this library!

I see your point. I will remove the import of css in library, and let users import it themselves. It seems there isn't any reason to do it inside the library, and it will support better compatibility for use case like yours(Next.js).

+) Also will modify sample usage code on documentation

Reference