cafejojo/schaapi

Rename `TestableGenerator` class to `ClassGenerator`

JSAbrahams opened this issue · 4 comments

JSAbrahams commented

In most cases, the class names are identical to the interfaces they implement, or an amalgamation of names such as JavaMavenProject, which implements JavaProject and MavenProject, or just simply an extension of the name as is the case with the filters.

However TestableGenerator seems to be the exception, so would it perhaps be an idea to rename the class to ClassGenerator, which is perhaps more indicative of what is actually does anyway. See PR #76 for comment that sparked issue.

FWDekker commented

In the original design, TestableWriter and TestableGenerator were separated. However, the writer part is no longer part of the interface. Therefore, we should be able to call the TestableGenerator whatever we want. We could even call it the ClassWriter or the FooBarBar.

gandreadis commented

+1 for FooBarBar
How about TestableClassGenerator?

  • 😄1
FWDekker commented

@gandreadis Considering that the current TestableGenerator does not do anything specific to tests, I think ClassWriter/ClassGenerator would be a better name.

gandreadis commented

Hmm yeah, fair point. In that case, ClassGenerator seems the best option to me