[problem] Fail to run the test command in Makefile

[gaocegege]

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

What happened:

When I run make, code here output an error to STDERR:

/bin/sh: 1: [[: not found

What you expected to happen:

Generate v-dirty if there are changes, generate v if there is no change.

How to reproduce it (as minimally and precisely as possible):

nirvana init ./myproject
cd ./myproject
make

Solution

COMMIT := $(COMMIT)$(shell git diff-files --quiet || echo '-dirty')

[kdada]

Please test it in MacOS and Linux.

[gaocegege]

I have no macOS machine now. The problem can be reproduced in Linux (4.4.0-78-generic).

[caitong93]

I test this on Mac, CentOS and Ubuntu. Only reproduced on Ubuntu.
This is caused by difference of sh and bash.
On CentOS and Mac, /bin/sh(or /usr/bin/sh) is a symbol link to bash.
And solution by @gaocegege work fine on all these systems.

[kdada]

@gaocegege please file a PR to fix it.