remove the deprecated `CloseNotify` function
Opened this issue · 1 comments
iawia002 commented
Is this a BUG REPORT or FEATURE REQUEST?:
Uncomment only one, leave it on its own line:
/kind bug
/kind feature
What happened:
Lines 208 to 211 in 854a462
the original CloseNotifier
interface was marked as Deprecated
since Go 1.11, the user should use http.Request.Context.Done()
as instead. Should we remove this too?
PS: this will trigger a lint problem (#287)
What you expected to happen:
How to reproduce it (as minimally and precisely as possible):
Anything else we need to know?:
/cc @kdada
kdada commented
Just do it.