Make this project build using PowerShell 2.0

Question

Make this project build using PowerShell 2.0

Closed this issue 8 years ago · 8 comments

The new plan going forward is to always update this projects bootstrapper when changes are made to the bootstrapper in the resources repository. In order to keep compatibility with PowerShell 2.0, I think it makes a lot of sense to force our AppVeyor build to use version 2 of PowerShell. That way, if the build fails, we know we have broken something.

Thoughts @devlead

Answer 1 · 2016-07-20T11:36:38.000Z

@gep13 agree makes sense, it's just an flag to PowerShell exe to force it into version 2 mode.

Answer 2 · 2016-07-20T12:00:10.000Z

@devlead yip, that is what I thought. So I was thinking just to change the appveyor.yml file to use a cmd command, and call powershell from there?

Answer 3 · 2016-07-20T12:03:14.000Z

@gep13 sounds reasonable👍 Important part is that we get the exit code, so build still fails on failure but that's easy to test with bogus PR afterwards.

Answer 4 · 2016-08-17T12:13:29.000Z

@gep13 example now builds using PowerShell V2

Answer 5 · 2016-08-17T12:24:33.000Z

@devlead should we have this in an appveyor.yml file?

Answer 6 · 2016-08-17T12:26:20.000Z

Don't think we should force people to use PowerShell 2.

Answer 7 · 2016-08-17T12:36:29.000Z

@devlead said...
Don't think we should forcepeople to use PowerShell 2.

Aou lost me. Are you talking about people forking this repo, and therefore having the same appveyor.yml? Otherwise, I don't see how we would be forcing anyone to do anything. I was suggesting putting it in our own appveyor.yml file, simply as a reminder that we are doing that, rather than having to go back to the AppVeyor UI.

Answer 8 · 2016-08-17T12:40:24.000Z

fair point exported and added the config used now.