cake-contrib/Cake.SqlPackage

Recommended changes resulting from automated audit

Closed this issue · 1 comments

Jericho commented

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

  • You are currently referencing Cake.Core 0.26.0. Please upgrade to 0.28.0
  • The Cake.Core reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Core" Version="0.28.0" PrivateAssets="All" />
  • Your addin should target netstandard2.0. Please note that there is no need to multi-target, netstandard2.0 is sufficient.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.org and in the project on github.

Jericho commented

We performed a follow up automated audit of your Cake addin and found that the issues we previously identified have been resolved. Thank you!

Please be aware that some of the recommendations we made in our last audit (which took place in June 2018) have changed. For instance, we now recommend that addins use Cake 0.33.0 (rather than 0.28.0) and also, due to the announced demise of the rawgit CDN, we ask that you use a new icon URL.

All this to say that a future automated audit may create a new issue if you haven't already addressed these new recommendations.