cakephp/cakephp

Strpos result comparison

yannouche34490 opened this issue · 3 comments

yannouche34490 commented

cakephp/src/Console/BaseCommand.php

Line 49 in fe40e4f

if (strpos($name, ' ') < 1) {

Description

Hello,

when you make comparison between strpos result and 1, PHP will cast the result to a int even if function returns false. It can result an unexpected true comparison.

Best regards.

CakePHP Version

4.4.0

PHP Version

8.2

dereuromark commented

Is it actually a Bug? From what I understand this is intentional here

ADmad commented

The check is to throw an exception if a space is found at the first position (strpos will return 0) or if the name does not have a space (strpos will return false) and it works as intended.

yannouche34490 commented

The check is to throw an exception if a space is found at the first position (strpos will return 0) or if the name does not have a space (strpos will return false) and it works as intended.

Oh by mad, I didn't think things like that.