None of the commands work

Question

None of the commands work

Closed this issue 10 years ago · 40 comments

As of the v2 release none of the commands seems to work, they all return an empty list, so that you can't choose a song/album/etc. to play.

Answer 1 · 2014-11-12T13:14:47.000Z

Here's the error message from Alfred's debug console:

Starting debug for 'Play Song'

[ERROR: alfred.workflow.input.scriptfilter] Code 1: execution error: Finder got an error: AppleEvent handler failed. (-10000)
[ERROR: alfred.workflow.input.scriptfilter] Code 1: execution error: Finder got an error: AppleEvent handler failed. (-10000)
[ERROR: alfred.workflow.input.scriptfilter] Code 1: execution error: Finder got an error: AppleEvent handler failed. (-10000)
[ERROR: alfred.workflow.input.scriptfilter] Code 1: execution error: Finder got an error: AppleEvent handler failed. (-10000)
[ERROR: alfred.workflow.input.scriptfilter] Code 1: execution error: Finder got an error: AppleEvent handler failed. (-10000)
[ERROR: alfred.workflow.input.scriptfilter] Code 1: execution error: Finder got an error: AppleEvent handler failed. (-10000)
[ERROR: alfred.workflow.input.scriptfilter] Code 1: execution error: Finder got an error: AppleEvent handler failed. (-10000)

Answer 2 · 2014-11-12T17:30:26.000Z

Okay, I added a modified workflow on a new branch hotfix/2, which will log the error Alfred 'Workflow Data' folder does not exist if such is true. Please try it and report what happens.
Caleb

Answer 3 · 2014-11-12T17:51:07.000Z

I get that error with that version:

[ERROR: alfred.workflow.input.scriptfilter] Code 1: Alfred 'Workflow Data' folder does not exist
execution error: Finder got an error: AppleEvent handler failed. (-10000)
[ERROR: alfred.workflow.input.scriptfilter] Code 1: Alfred 'Workflow Data' folder does not exist
execution error: Finder got an error: AppleEvent handler failed. (-10000)
[ERROR: alfred.workflow.input.scriptfilter] Code 1: Alfred 'Workflow Data' folder does not exist
execution error: Finder got an error: AppleEvent handler failed. (-10000)

Answer 4 · 2014-11-12T17:57:46.000Z

However, inserting the line tell application "Finder" to return (alias alfredWorkflowDataFolder exists) after the property-statements in Configuration.scpt and running from the Script Editor, I get true as the result.

So it seems like the problem is running it from Alfred.

Answer 5 · 2014-11-12T19:23:13.000Z

Ah, okay. Well, in that case, can you change the log message in Configuration.scpt from this:

log "Alfred 'Workflow Data' folder does not exist"

To this:

log ("Alfred 'Workflow Data' folder does not exist: " & (alfredWorkflowDataFolder as text))

Please post the output from the debugger. I have a feeling that AppleScript within Alfred might be improperly constructing the path.

Answer 6 · 2014-11-12T19:41:37.000Z

I still get the same output:

[ERROR: alfred.workflow.input.scriptfilter] Code 1: Alfred 'Workflow Data' folder does not exist
execution error: Finder got an error: AppleEvent handler failed. (-10000)
[ERROR: alfred.workflow.input.scriptfilter] Code 1: Alfred 'Workflow Data' folder does not exist
execution error: Finder got an error: AppleEvent handler failed. (-10000)
[ERROR: alfred.workflow.input.scriptfilter] Code 1: Alfred 'Workflow Data' folder does not exist
execution error: Finder got an error: AppleEvent handler failed. (-10000)
[ERROR: alfred.workflow.input.scriptfilter] Code 1: Alfred 'Workflow Data' folder does not exist
execution error: Finder got an error: AppleEvent handler failed. (-10000)

which probably means that Alfred uses a cached version of Configuration.scpt and doesn't update it when installing the workflow.

Answer 7 · 2014-11-12T19:48:32.000Z

And it gets even weirder:

Replacing /Users/Tyilo/Library/Application\ Support/Alfred\ 2/Alfred.alfredpreferences/workflows/user.workflow.*/Configuration.scpt with the one from hotfix/2 I still get the error.

However changing /Users/Tyilo/Library/Application\ Support/Alfred\ 2/Alfred.alfredpreferences/workflows/user.workflow.*/Configuration.scpt directly and changing that line to log ("Alfred 'Workflow Data' folder does not exist: " & (alfredWorkflowDataFolder as text)) have fixed the issue completely! No error is logged and playing works!

Answer 8 · 2014-11-12T19:55:23.000Z

That's so bizarre. I wonder if compiling the AppleScript (as you might do in the editor) has something to do with this.

I am still determined to figure this out. Could you try the following:

Replace Configuration.scpt with the one from hotfix/2. See if this breaks the workflow again
Open Configuration.scpt (in the workflow itself) in the Script Editor and press the Compile button. See if the workflow works now

Answer 9 · 2014-11-12T20:02:24.000Z

It breaks it
This fixes it again. (Compile + save)

Answer 10 · 2014-11-12T20:07:00.000Z

Well, after some quick searching, I've discovered that this might not be an issue with Play Song, but with Alfred. Check out this thread on the Alfred Forums:
http://www.alfredforum.com/topic/1861-applescript-runs-differently-in-alfred-and-in-applescript-editor/

What do you think?

Answer 11 · 2014-11-12T20:12:03.000Z

What happens if you change Configuration.scpt to a plaintext script (Configuration.applescript)?

Answer 12 · 2014-11-12T20:14:07.000Z

Making all the scripts plaintext is probably also a good idea for viewing the files on GitHub and viewing diffs in git.

Answer 13 · 2014-11-12T20:15:02.000Z

AppleScript can only load in scpt files into memory. I could convert them, but then I can't run them in the Script Editor. That might be an acceptable sacrifice, though—version control is more important.

However, I've pushed a new possible fix for hotfix/2 branch. Please download and replace the workflow (yes, the entire workflow) with the new copy. Test the play keyword only. I added a single line after loading in the config script which runs it afterward (run script config), which might trigger a compile and cause it to work.

Answer 14 · 2014-11-12T20:34:57.000Z

It still doesn't work, however you can use this bash script to automatically recompile the script:

bundleid="com.calebevans.playsong"

container=""
for f in ~/Library/Application\ Support/Alfred\ 2/Alfred.alfredpreferences/workflows/user.workflow.*/; do
    if plutil -extract bundleid xml1 "$f/info.plist" -o - | grep "$bundleid" &> /dev/null; then
        container="$f"
        break
    fi
done

if [[ "$container" = "" ]]; then
    echo 'Failed to find workflow container directory!'
    exit 1
fi

for f in "$container"/*.scpt; do
    plaintext=$(osadecompile "$f")
    # | sponge |
    echo "$plaintext" | osacompile -o "$f"
done

echo 'Recompiled scripts!'

Answer 15 · 2014-11-12T23:51:21.000Z

Oh, that's handy. I'm not sure where/how you came up with that, but cool.

Assuming a modify that bash script accordingly, do you think I could run it on the exported workflow before committing in order to make the workflow work for everyone else? I would not prefer that users of the workflow need to run this in order for the workflow to function, though I wouldn't mind doing so as a final step before committing a new version of the workflow.

Answer 16 · 2014-11-12T23:53:33.000Z

I doubt it, as it just does the same as clicking compile and save in Script Editor.

Answer 17 · 2014-11-13T02:11:49.000Z

Okay, I've pushed a new update to hotfix/2, this time with the configuration nested inside a script object within the file (which I'm hoping might compile). Please test it and let me know if it works or not (again, test only the play keyword). :)

Thanks,
Caleb

Answer 18 · 2014-11-13T02:15:24.000Z

Nope still get the error:

[ERROR: alfred.workflow.input.scriptfilter] Code 1: execution error: Finder got an error: AppleEvent handler failed. (-10000)
[ERROR: alfred.workflow.input.scriptfilter] Code 1: execution error: Finder got an error: AppleEvent handler failed. (-10000)
[ERROR: alfred.workflow.input.scriptfilter] Code 1: execution error: Finder got an error: AppleEvent handler failed. (-10000)

Running my script however still fixes it.

Answer 19 · 2014-11-13T06:03:34.000Z

Ah, well, I'm still not giving up.

I've pushed another update to hotfix/2. Please replace the workflow, test the play keyword, and let me know if the results show up this time.

Answer 20 · 2014-11-13T10:11:26.000Z

Still doesn't work :/

Answer 21 · 2014-11-13T10:32:01.000Z

I have recompiled the latest hotfix/2 Configuration.scpt and uploaded it here: https://a.pomf.se/mkoccc.scpt

If you use that without recompiling it yourself, does it work for you?

Answer 22 · 2014-11-13T16:34:45.000Z

I don't think it would matter, anyway. The workflow has been working for me from the very beginning.

However, because we've narrowed the problem down to a compilation issue, and because I've messed around so much with hotfix/2, I decided to delete the branch and re-branch from master. This time, though, I compiled Configuration.scpt using the above Bash script before exporting the workflow and committing.

Please test and see if the workflow on hotfix/2 works for you.

Answer 23 · 2014-11-13T16:55:24.000Z

Still doesn't work. I think you might need to include the bash script and run it on installation (or first run) somehow.

Answer 24 · 2014-11-13T18:42:40.000Z

Hmm, I think you're right. Therefore, I decided to include compile.sh with the workflow and execute it (via do shell script) when filtering the list of songs.

Again, please test the play keyword and see if it works for you. I realize that it's not at all efficient—it recompiles Configuration.scpt on every keystroke—but I'm just taking this one step at a time.

Caleb

Answer 25 · 2014-11-14T23:27:14.000Z

@tyilo, any updates?

Answer 26 · 2014-11-15T00:07:17.000Z

Sorry I somehow missed the email sent by GitHub.

It works for me now out of the box! 😄

Answer 27 · 2014-11-15T00:15:44.000Z

YES, FINALLY! I can't begin to tell you how happy I am.

Thank you so very much for all of your help in diagnosing this issue. We're almost done. ;)

Now, I shall apply the fix to the other parts of the workflow (in addition to optimizing the Bash script to run once). I hope to push the updated build to GitHub within the next few days, at which point I will need your assistance one last time to ensure that everything works.

Caleb

Answer 28 · 2014-11-15T00:18:44.000Z

Cool, thanks ;)

Answer 29 · 2014-11-15T00:22:04.000Z

Also @tyilo, do you know of any way to detect (via Bash) if an AppleScript (*.scpt) has been compiled? I'm pondering ways to detect when the script has already been compiled, and so far, I can only think of the "create some file and check if it exists" approach.

Answer 30 · 2014-11-15T00:27:52.000Z

Maybe by running the Configuration.scpt with osascript and checking if the workflow data path exists? I'm not sure that it will work, as I think that the problem occurs when Alfred is running it.

An alternative solution: don't include Configuration.scpt, but include Configuration.applescript instead. Then check if Configuration.scpt exists, if not then run osacompile < Configuration.applescript -o Configuration.scpt.

Answer 31 · 2014-11-15T00:33:09.000Z

I think that alternative solution is quite brilliant. Implementing it would enable me to more easily migrate from .scpt files to .applescript files. That is, I would never need to manually compile Comfiguration.applescript into Configuration.scpt—the workflow would handle that for me.

I will surely implement this and respond here once I do. :)
Caleb

Answer 32 · 2014-11-15T00:34:08.000Z

While you're at it convert the other .scpt to .applescript too if possible.

Answer 33 · 2014-11-15T00:36:36.000Z

Oh, believe me—I was already planning on it. Long live UTF-8!

Answer 34 · 2014-11-15T01:51:52.000Z

Okay, @tyilo, I implemented the fix! Please download the workflow from hotfix/2 and test all aspects of the workflow so I can merge this in.

Thanks very much,
Caleb

Answer 35 · 2014-11-15T02:15:31.000Z

Damn, I get the same error again:

[ERROR: alfred.workflow.input.scriptfilter] Code 1: execution error: Finder got an error: AppleEvent handler failed. (-10000)

The Configuration.scpt exists in the workflows folder after trying to use play, however it doesn't seem to work. However if I manually go to that directory and delete the Configuration.scpt and run bash ./compile.sh it works! This doesn't make any sense to me at all.

Answer 36 · 2014-11-15T02:26:46.000Z

Oh, duh. Just realized that I left my already-compiled version of Configuration.scpt in the workflow folder before exporting. If I delete it, a new compiled version should automatically be created when you run the workflow.

Hang on,
Caleb

Answer 37 · 2014-11-15T02:28:31.000Z

Okay, @tyilo, pushed a new commit to hotfix/2 branch. Again, please download and test—it should work this time.

Caleb

Answer 38 · 2014-11-15T02:29:51.000Z

It works, yay!

Answer 39 · 2014-11-15T02:32:53.000Z

Fantastic—absolutely fantastic. Let's merge this in and go home. ;)

Thanks again so very much for all of your help.
Caleb

Answer 40 · 2014-11-15T02:36:08.000Z

And... the fix has been merged in! I will gladly close the issue now. :)

Caleb