calibreapp/react-live-chat-loader

Lighthouse aria-* rule violation

luisrudge opened this issue · 3 comments

luisrudge commented

Describe the bug

Lighthouse is complaining about an aria-* rule violation: [aria-*] attributes do not match their roles

How To Reproduce

          <LiveChatLoaderProvider providerKey="lksanlsknksal" provider="drift">
             ...
            <Drift />
          </LiveChatLoaderProvider>

Expected behaviour

No accessibility errors should be present

Screenshots

image

benschwarz commented

Hey @luisrudge, thanks for logging this.

Are you aware of how the aria attributes are mismatched or what a fix might be?

If so, please feel free to file a PR correcting behaviour, or add notes here with any additional information you're able to provide.

luisrudge commented

I did some research and according to this I think you can't apply aria-label without having a role as well.

image

benschwarz commented

Thanks for reporting AND fixing @luisrudge 🥇 Appreciated 👍

We've just merged your change and added you as a contributor. Release 2.7.2 is out the door!