callmeed/pop-playground

valueCount(nil) should be valueCount(0)

Opened this issue · 8 comments

The following line (53 in POPPropertyAnimationInternal.h) causes an error

 _POPPropertyAnimationState(id __unsafe_unretained anim) : _POPAnimationState(anim),
 ...
 valueCount(nil),
 ...

I believe the fix is as simple as changing it to valueCount(0), but maybe I'm overlooking something.

Full error: /Users/ryanmcleod/Code/pop-playground-master/Pods/pop/pop/POPPropertyAnimationInternal.h:53:3: Cannot initialize a member subobject of type 'NSUInteger' (aka 'unsigned long') with an rvalue of type 'nullptr_t'

I got the same error. Anyone have an idea?

Replacing it with '0' seems to be okay.

On Wed, Mar 4, 2015 at 11:55 AM, Nick Bewley notifications@github.com
wrote:

I got the same error. Anyone have an idea?

Reply to this email directly or view it on GitHub:
#5 (comment)

Same error here, replacing with 0 seems to work

Could someone PR?

Thanks

It appears this got fixed in Pop awhile back, that said I just cloned this repo fresh and was able to build without issue? If you're still having it though, perhaps you could pod update and pod install?

Ok I updated the podlock


Sent from Mailbox

On Mon, May 18, 2015 at 5:02 PM, Ryan McLeod notifications@github.com
wrote:

It appears this got fixed in Pop awhile back, that said I just cloned this repo fresh and was able to build without issue? If you're still having it though, perhaps you could pod update and pod install?

Reply to this email directly or view it on GitHub:
#5 (comment)

👍

On Mon, May 18, 2015 at 3:21 PM, Francescu Santoni
notifications@github.com wrote:

Ok I updated the podlock

Sent from Mailbox
On Mon, May 18, 2015 at 5:02 PM, Ryan McLeod notifications@github.com
wrote:

It appears this got fixed in Pop awhile back, that said I just cloned this repo fresh and was able to build without issue? If you're still having it though, perhaps you could pod update and pod install?

Reply to this email directly or view it on GitHub:

#5 (comment)

Reply to this email directly or view it on GitHub:
#5 (comment)