What Mime is supported/returned
MathieuUrstein opened this issue · 1 comments
MathieuUrstein commented
Question
The documentation never refers to Mimes.
- Can all
image/*
be passed as theuri
parameter? - Is the returned uri in the same Mime format or is it converted?
- Is this the same on both platforms?
In the usage example documentation, there is a mismatch between the log uri
& the param url
:
ImageEditor.cropImage(uri, cropData).then(url => {
console.log("Cropped image uri", url);
})
The promise probably returns an uri right?
- ImageEditor.cropImage(uri, cropData).then(url => {
+ ImageEditor.cropImage(uri, cropData).then(uri => {
- console.log("Cropped image uri", url);
+ console.log("Cropped image uri", uri);
})
In the documentation you mention:
Remember to delete the cropped image from the cache path when you are done with it.
The documentation does not give an example for that, neither can I find one in the example app.
It would be welcomed to have such an example 😀.
I'm writing this as an issue instead of a stackoverflow question because this should end up as a PR to at least correct the README usage example uri/url mismatch
retyui commented
Hi @MathieuUrstein README was updated and library API has changed to make it more clear to understand