callstack/reassure

[Improvement] replace the unmaintained markdown-builder package

meteorlxy opened this issue · 2 comments

Describe the improvement

The markdown-builder package is no longer maintained since 2019.

It introduces a redundant legacy version of husky in its dependencies, which pollutes the dependency tree:

reassure/yarn.lock

Lines 6318 to 6323 in 0482568

markdown-builder@^0.9.0:
version "0.9.0"
resolved "https://registry.yarnpkg.com/markdown-builder/-/markdown-builder-0.9.0.tgz#bd583ae705889da25f8270edb4b3171ff649c5bb"
integrity sha512-UovCyEEzMeKE7l88fbOk9SIJkOG7KXkg+TdudN8rvOtCtBO5uu1X27HSnM7LS/xH+vaShJLGpkBcYYcojWNx/g==
dependencies:
husky "^1.0.0-rc.14"

Although it could be resolved by the "resolutions" feature of some package manager, I think it could be better to replace it totally from the @callstack/reassure-compare package.

I found there is a fork mr_markdown_builder and maybe we can make use of it directly?

Hey, would you like to contribute this in a pull request maybe? :)

I've did a quick check where do we use markdown builder and it's pretty minimal. We just use headers.h1, headers.h3 emphasis.b and emphasis.i. Replacements for this should be easy to add to reassure-compare directly. @meteorlxy would you like to contribute it?