camspiers/dotfiles

Questions about openterm() / lazygit

Closed this issue · 1 comments

Hey there,

I was wondering if you would be willing to help me integrate some of your config into my system :)

A while back, I saw your reddit post about having lazygit open in a floating window in nvim, and thought it was really cool, so I decided to copy it to my config. It worked really well until very recently, when I noticed that the lazygit window inside the float was shifted to the left by a couple of columns, resulting in the left margin being cut off:

Left-shifted lg

I tried tweaking the code I copied from you but wasn't able to fix it, so I decided to check your repo in case you'd encountered the same issue and implemented a fix. I saw that you had refactored your code in the meantime and re-implemented the floating term stuff into its own plugin. So I tried your new code, but for some reason it tries to open the new term in a one-line-high bottom split (you can just see lazygit complaining about not having enough space):

Tiny lg split

Would you have any pointers for me as to what could be causing either of these issues? I loved your very elegant float implementation and would like to continue using it, but I know absolutely nothing about this aspect of nvim.

Many thanks!

Figured it out: I installed your animate.vim plugin (I had previously decided against it because I didn't think I had a usecase for it) and with it enabled, lazygit opens beautifully. I still don't know why the lazygit output was broken in the old floating window, but this new solution works fine for me. Sorry for bothering you & thanks for your cool stuff!