Additional files deployment not working after latest update

Question

Additional files deployment not working after latest update

Closed this issue 6 days ago · 16 comments

Describe the bug

I'm unable to attach more than one file to a process deployment after updating to v5.29. Disabling all plugins had no effect.

Steps to reproduce

Open a bpmn file
Click the deployment button
Select multiple additional files
Only the first file is shown
Click deploy
If the deployment is successful, only the first selected file is deployed
Regardless of whether the deployment was successful or not, subsequent attempts are not possible because the deployment button becomes unresponsive
The following output is shown in DevTools after clicking the deployment button:

Expected behavior

Multiple files should be attached and deployed

Environment

OS: Windows 11 and Windows 10
Camunda Modeler Version: 5.29
Execution Platform: Camunda 7

Additional context

No response

Answer 1 · 2024-11-14T15:46:51.000Z

Thank you for reporting. I can reproduce it in 5.29.0 only. This is a regression.

Answer 2 · 2024-11-18T02:23:54.000Z

This is being caused by a breaking change in Electron:
https://www.electronjs.org/docs/latest/breaking-changes#removed-filepath

Answer 3 · 2024-11-20T08:21:10.000Z

I am looking into this issue right now. I noticed that the saved configuration is broken too, as we "serialize" the files to this:

[
  { "path": undefined }
]

Answer 4 · 2024-11-20T11:24:27.000Z

I have this problem on both 5.28 and 5.29

Answer 5 · 2024-11-20T12:06:48.000Z

A fix is in progress :)

Answer 6 · 2024-11-20T12:10:11.000Z

Thank you @bMarc. I just ran a local build on osx (ARM) from branch 24694-make-multi-file-deployment-work-again- can confirm - its not fixed yet. Will track the merge. Again: thank you very much.

Answer 7 · 2024-11-20T12:17:47.000Z

Can you paste here the contents of the devtools when you encounter the problem on my branch? You can access it with F12.
This might be a problem with preexisting configuration.

Answer 8 · 2024-11-20T12:24:12.000Z

DeploymentTool.js:683 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'split')
    at DeploymentTool.js:683:19
    at async Promise.all (index 0)
    at async tt.withAttachments (DeploymentTool.js:462:11)
    at async tt.getSavedConfiguration (DeploymentTool.js:370:7)
    at async tt.deployTab (DeploymentTool.js:123:9)

Answer 9 · 2024-11-20T12:25:38.000Z

Thanks. It looks that we'd need to handle the broken config in that case.
When you deploy, we save the last configuration. Files are serialized as { path: string } objects, but since path is missing, the serialization fails silently.

Answer 10 · 2024-11-20T12:28:19.000Z

Are you about to create an automated repair of the configuration then? Or shall/ may/ I try fix the config manually in my case as this is supposedly a one time only problem?

Answer 11 · 2024-11-20T12:30:59.000Z

Can you please check if the deployment works for you with the current contents of the branch? We will likely fail gracefully, so there will be no file read from the config as path is missing, but at least you can deploy.

Answer 12 · 2024-11-20T12:35:10.000Z

This is how it is supposed to look for the legacy-broken config:

Answer 13 · 2024-11-20T12:39:25.000Z

Yes. Confirmed:

After deleting and adding the correct form files. The deployed worked again. Further deployments seem to be working too. Awesome. Thank you.

Answer 14 · 2024-11-20T12:40:50.000Z

Great! Thank you for your support :)

Answer 15 · 2024-11-20T12:41:10.000Z

The fix will land in the upcoming 5.30.0 release.

Answer 16 · 2024-11-21T08:04:37.000Z

Closed via #4708