Feature: add support for `GS_CAN_FEATURE_GET_STATE` and `GS_CAN_FEATURE_BERR_REPORTING`
Opened this issue · 5 comments
marckleinebudde commented
In this issue I want to track implementation of the GS_CAN_FEATURE_GET_STATE
and GS_CAN_FEATURE_BERR_REPORTING
features.
@jhofstee, do you have some work-in-progress code somewhere? Is the newest code in this branch? https://github.com/jhofstee/candleLight_fw/tree/canbus-state
marckleinebudde commented
marckleinebudde commented
In #124 (comment) @jhofstee says his implementation can be rebased to mainline.
marckleinebudde commented
FTR: The new features have been documented in #124.
Linux support has been mainlined with torvalds/linux@0c9f92a
fenugrec commented
I wonder if this could be extended to count dropped frames (RX overflows) ...
marckleinebudde commented
We already have the GS_CAN_FLAG_OVERFLOW
to signal a RX overflow to Linux:
candleLight_fw/include/gs_usb.h
Line 83 in 4a1e646
It's not used in the candlelight FW, though.