firmware echos "hf->flags" which might cause spurious ERRORFRAMEs in Linux

[marckleinebudde]

Brian Silverman brian.silverman@bluerivertech.com posted the following patch on the Linux CAN mailing list:

https://lore.kernel.org/all/20220106002952.25883-1-brian.silverman@bluerivertech.com/

No information is deliberately sent here in host->device communications,
but the open-source candleLight firmware echoes it back, which can
result in the GS_CAN_FLAG_OVERFLOW flag being set and generating
spurious ERRORFRAMEs.

Signed-off-by: Brian Silverman brian.silverman@bluerivertech.com

 drivers/net/can/usb/gs_usb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c
index 1b400de00f51..cc4ad8d59bd7 100644
--- a/drivers/net/can/usb/gs_usb.c
+++ b/drivers/net/can/usb/gs_usb.c
@@ -507,6 +507,7 @@ static netdev_tx_t gs_can_start_xmit(struct sk_buff *skb,

        hf->echo_id = idx;
        hf->channel = dev->channel;
+       hf->flags = 0;

        cf = (struct can_frame *)skb->data;

[marckleinebudde]

FYI: @bsilver8192