[request] Increase the 79 character line length limit
Opened this issue · 5 comments
Pweaaaseee can we increase the max line length to 120 chars. I'm begging dawg.
I value more verbose and informative variable names but this makes dealing with 79 chars max width impossible, especially after a few indents 😭
I'm willing to bargain. Even 100 would be a night and day difference vs 79. Heck, I'll work in exchange for having my needs met. Just say the word. I'll tattoo pycloudlib on my left thigh if I have to. Let's make it happen, guys, girls, and enbies.
Thanks for hearing me out :P
I value more verbose and informative variable names but this makes dealing with 79 chars max width impossible
How long we talking? Install ruff into your editor and it should "just work" and automatically reformat things for most of these issues unless you want like 50+ character names, but I'd think those should be fairly rare. You just have to get used to more vertical space rather than horizontal.
That said, I don't personally have a problem increasing it, but we'll want to make sure others are on board. It'll be an ugly commit due to auto-reformatting so many lines, but .git-blame-ignore-revs should help with that somewhat. I asked about doing the same in this repo and in cloud-init a couple years back, and the main reasons I got for current values are:
- pep8 default
- If you have to edit code in a serial console (which is your only option if you have no network in a cloud instance), 80 chars is still your max-width there.
- A previous maintainer liked being able to have 4 code columns side-by-side.
The serial console issue could still be relevant, but I don't see it as a large blocker, so count me as +1 to a 100-char line.
The serial console issue could still be relevant, but I don't see it as a large blocker, so count me as +1 to a 100-char line.
This project is really a library used in test infrastructure - I don't know of anywhere that this is considered a part of a production service. I'm having a hard time imagining a scenario where someone would be debugging pycloudlib from a console in a datacenter, so +1 from me.
A previous maintainer liked being able to have 4 code columns side-by-side.
Haha honestly I completely get that, and for that reason too, I'd be happy to just set line length to 100 instead of 120
+1, thanks for rising this up!
100 it is!