It would be nice to have tests for the lib
jackrwright opened this issue · 3 comments
jackrwright commented
Any thoughts on how to add meaningful tests for the lib?
jimmy0251 commented
Hi @jackrwright Hope you are doing well.
Any luck on updating tests to use public APIs? Let me know if you think you will not have time to do it. I'm planning to add some tests as well, in that case we should close the PR.
jackrwright commented
Hi Jimmy,
Sorry for the delay. I’ve been swamped with other work. Please feel free to close the PR and add the tests you were planning.
Jack
… On May 9, 2022, at 2:37 AM, Jimmy Sanghani ***@***.***> wrote:
Hi @jackrwright <https://github.com/jackrwright> Hope you are doing well.
Any luck on updating tests to use public APIs? Let me know if you think you will not have time to do it. I'm planning to add some tests as well, in that case we should close the PR.
—
Reply to this email directly, view it on GitHub <#17 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFLKF2FDQNB354KI3NVHX7TVJCXCHANCNFSM5THKADXQ>.
You are receiving this because you were mentioned.
jimmy0251 commented
Thanks a lot!