mcfly stopped working (kernel issue)

Question

mcfly stopped working (kernel issue)

hferreiro opened this issue a year ago · 17 comments

Since some time ago, I cannot get mcfly to work. After running its UI with ctrl-r, pressing enter or tab on any row just goes back to bash with an empty prompt.

I tried emptying my .bashrc or running mcfly -d search directly without success. Is there any way to debug this issue?

Answer 1 · 2023-07-07T21:30:00.000Z

Does mcfly --version give output? And I assume you have eval "$(mcfly init bash)" in your bashrc?

Answer 2 · 2023-07-09T11:41:59.000Z

I got the same mistake, and this is my bash and mcfly versions:
bash: 5.2.15
mcfly: 0.8.1

Answer 3 · 2023-07-09T11:46:33.000Z

this issue would help:
dvorka/hstr#478

Answer 4 · 2023-07-10T08:39:23.000Z

Does mcfly --version give output? And I assume you have eval "$(mcfly init bash)" in your bashrc?

Yes, it's initialized as that. Running mcfly works, what's not working is selecting something in its UI.

Answer 5 · 2023-07-10T08:41:16.000Z

this issue would help: dvorka/hstr#478

I can confirm this is the issue. The workaround at dvorka/hstr#478 (comment) is working for me:

$ sysctl -w dev.tty.legacy_tiocsti=1

Answer 6 · 2023-07-16T17:42:16.000Z

@cantino hstr is going to fix the same issue in the next release: dvorka/hstr#486. Would mcfly fix this?

Answer 7 · 2023-08-17T22:01:07.000Z

If someone wants to work on this, I'd be happy to accept a fix. Does setting READLINE_LINE have the same effect as using tiocsti?

Answer 8 · 2023-08-25T18:40:20.000Z

+1 for the fix, odd!

Answer 9 · 2023-10-29T22:40:21.000Z

Fresh install of EndeavourOS, same issue:

GNU bash, version 5.1.16(1)-release (x86_64-pc-linux-gnu)
mcfly 0.8.1

Thanks for the fix hferreiro

Answer 10 · 2024-02-11T08:18:50.000Z

$ sysctl -w dev.tty.legacy_tiocsti=1 do we still have to use this? Also does it need to be turned off when we git a fix in mcfly?

Kernel: 6.7.4-zen1-1-zen

Answer 11 · 2024-02-12T00:10:23.000Z

$ sysctl -w dev.tty.legacy_tiocsti=1 do we still have to use this? Also does it need to be turned off when we git a fix in mcfly?
Kernel: 6.7.4-zen1-1-zen

I'm still needing to run this in my terminal to be able to use McFly. The latest Kernel and updates were applied yesterday.

Answer 12 · 2024-02-14T17:10:20.000Z

$ sysctl -w dev.tty.legacy_tiocsti=1 do we still have to use this? Also does it need to be turned off when we git a fix in mcfly?
Kernel: 6.7.4-zen1-1-zen

I'm using Debian Testing with kernel version 6.6.13-amd64, and my current mcfly of version 0.8.4 just works without any special configuration at all, although the kernel config doesn't set tiocsti:

Answer 13 · 2024-04-08T08:36:56.000Z

For me:

❯ uname -r
6.8.0-76060800daily20240311-generic
❯ cat /boot/config-6.8.0-76060800daily20240311-generic | rg TIOCSTI
# CONFIG_LEGACY_TIOCSTI is not set
❯ source /etc/os-release ; echo $VERSION
22.04.4 LTS (Jammy Jellyfish)

it is needed to set dev.tty.legacy_tiocsti=1, to work around this issue.

Answer 14 · 2024-04-08T22:11:40.000Z

This works on Arch (EndeavourOS) to make the fix survive a reboot:

echo "dev.tty.legacy_tiocsti=1" | sudo tee -a "/etc/sysctl.d/custom.conf"

Answer 15 · 2024-04-28T23:24:46.000Z

Confirmed this is #333

Answer 16 · 2024-05-13T21:38:25.000Z

Is there a workaround for systems where you don't have root access?

Answer 17 · 2024-05-26T03:19:38.000Z

Closed, this is #333.