Version 0.3.0 has dependency of Capacitor 3

Question

Version 0.3.0 has dependency of Capacitor 3

salohcin714 opened this issue 4 years ago · 14 comments

Describe the bug
firebase-analytics@0.3.0 has dependency @capacitor/core@^3.0.0. Capacitor 3 support looks to be in beta and has not yet been officially released. Plugins behave differently in Capacitor 3 and this is causing the plugin to no longer function with Capacitor 2 projects.

This is causing the following error:

Error: node_modules/@capacitor-community/firebase-analytics/node_modules/@capacitor/core/types/definitions-internal.d.ts:16:18 - error TS2430: Interface 'CapacitorInstance' incorrectly extends interface 'CapacitorGlobal'.
  Types of property 'Plugins' are incompatible.
    Property 'FirebaseAnalytics' is missing in type '{ [pluginName: string]: { [prop: string]: any; }; }' but required in type 'PluginRegistry'.

16 export interface CapacitorInstance extends CapacitorGlobal {
                    ~~~~~~~~~~~~~~~~~

  node_modules/@capacitor-community/firebase-analytics/dist/esm/definitions.d.ts:3:9
    3         FirebaseAnalytics: FirebaseAnalyticsPlugin;
              ~~~~~~~~~~~~~~~~~
    'FirebaseAnalytics' is declared here.

To Reproduce
Steps to reproduce the behavior:
Run production build on Angular project using @capacitor/core@^2.4.7 and firebase-analytics@0.3.0.

Expected behavior
Type definitions to work properly with Capacitor 2 until support for Capacitor 3 is officially released

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

OS: macOS
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Angular: 11.0.2

Answer 1 · 2021-05-19T23:04:56.000Z

After further investigation, it looks like the dependency is actually @capacitor/core@latest which is now Capacitor 3 since it is now out of beta

Answer 2 · 2021-05-20T06:15:33.000Z

So could you please change the dependency to @capacitor/core@2.4.7 ?

Answer 3 · 2021-05-20T12:26:29.000Z

I created a pull request for a quick fix: #74

Answer 4 · 2021-05-20T21:40:44.000Z

Please fix! This plugin is currently breaking the build with both capacitor 2.4.7 and 3.0.

Answer 5 · 2021-05-21T08:30:32.000Z

I need someone who approves my "fix"

Answer 6 · 2021-05-21T11:39:12.000Z

I've just rolled out version 0.3.1 to npm with the merged PR, thanks everyone!

@all-contributors please add @tobium for code

Answer 7 · 2021-05-21T11:39:21.000Z

@brownoxford

I've put up a pull request to add @tobium! 🎉

Answer 8 · 2021-05-21T11:41:00.000Z

@all-contributors please add @slajar for review

Answer 9 · 2021-05-21T11:41:08.000Z

@brownoxford

I've put up a pull request to add @slajar! 🎉

Answer 10 · 2021-05-21T11:49:33.000Z

@all-contributors please add @salohcin714 for bug

Answer 11 · 2021-05-21T11:49:41.000Z

@brownoxford

I've put up a pull request to add @salohcin714! 🎉

Answer 12 · 2021-05-21T11:49:44.000Z

@tobium, @vanessag, @salohcin714 Please let me know whether this issue is resolved for you.

Answer 13 · 2021-05-21T19:42:23.000Z

@brownoxford I think I am having a different issue than the one in the original bug report. I am getting an error when building with Xcode:

/myApp/ios/App/Pods/GoogleDataTransport/GoogleDataTransport/GDTCCTLibrary/GDTCCTUploadOperation.m:36:9: 'GoogleUtilities/GULURLSessionDataResponse.h' file not found

I will open a new issue.

Answer 14 · 2021-05-26T13:56:21.000Z

Closing this issue out with the release of v0.3.2, please open another issue if new problems arise.