capawesome-team/capacitor-nfc

bug:

fozzarelo opened this issue · 0 comments

Plugin version:
5.0.2

Platform(s):
IOS

Current behavior:
Bad IOS target in node_modules/@capawesome-team/capacitor-nfc/CapawesomeTeamCapacitorNfc.podspec
It's at 12.0 and causes incompatibility further down

Expected behavior:
IOS target to be 13.0

Steps to reproduce:
npm installed, look at the mentioned file

Related code:

is

require 'json'

package = JSON.parse(File.read(File.join(__dir__, 'package.json')))

Pod::Spec.new do |s|
  s.name = 'CapawesomeTeamCapacitorNfc'
  s.version = package['version']
  s.summary = package['description']
  s.license = package['license']
  s.homepage = package['repository']['url']
  s.author = package['author']
  s.source = { :git => package['repository']['url'], :tag => s.version.to_s }
  s.source_files = 'ios/Plugin/**/*.{swift,h,m,c,cc,mm,cpp}'
  s.ios.deployment_target  = '12.0'
  s.dependency 'Capacitor'
  s.swift_version = '5.1'
end

should be

require 'json'

package = JSON.parse(File.read(File.join(__dir__, 'package.json')))

Pod::Spec.new do |s|
  s.name = 'CapawesomeTeamCapacitorNfc'
  s.version = package['version']
  s.summary = package['description']
  s.license = package['license']
  s.homepage = package['repository']['url']
  s.author = package['author']
  s.source = { :git => package['repository']['url'], :tag => s.version.to_s }
  s.source_files = 'ios/Plugin/**/*.{swift,h,m,c,cc,mm,cpp}'
  s.ios.deployment_target  = '13.0'
  s.dependency 'Capacitor'
  s.swift_version = '5.1'
end

Capacitor doctor:

Latest Dependencies:

  @capacitor/cli: 5.2.2
  @capacitor/core: 5.2.2
  @capacitor/android: 5.2.2
  @capacitor/ios: 5.2.2

Installed Dependencies:

  @capacitor/core: 5.0.0
  @capacitor/android: 5.0.0
  @capacitor/ios: 5.0.0
  @capacitor/cli: 5.2.2

[success] iOS looking great! 👌