capn-freako/PyBERT

Non-dismissable dialogs and program crash when Rx Cin value set out of range.

capn-freako opened this issue · 1 comments

Describe the bug
When I set the Rx Cin value to zero, which is below its allowed minimum value: 0.001, I get a couple error dialogs, which I can't dismiss by clicking on their "OK" buttons, and then the PyBERT program crashes.

To Reproduce
Steps to reproduce the behavior:

  1. Launch PyBERT normally.
  2. Set the value of Rx Cin to zero and hit <RET>.

Expected behavior
The value entry field for Rx Cin should turn red and the minimum value enforced when I attempt to enter zero.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: MacOS 10.14.6
  • Python Version 3.8.12
  • PyBERT Version 3.5.0.0 (not pushed yet)

Additional context

  1. Here is my relevant terminal output:

    (pybert-dev)
    dbanas@CapnFreakosMacBookPro:~
    $ python -m pybert
    objc[69010]: Attempt to use unknown class 0x7ff199f2ea00.
    Abort trap: 6
    
  2. Hitting <RET> succeeds in dismissing the error dialogs where clicking on their OK buttons fails.

  3. The Tx Cout field exhibits this same behavior.

Okay, I was able to fix this, by:

  1. Adding a high parameter to their Range() constructors, in pybert.py, and

  2. Adding the following line to their Item() descriptors, in pybert_view.py:

    editor=TextEditor(auto_set=False, enter_set=True, evaluate=float),