captivationsoftware/react-sticky

Content before Sticky component inside StickyContainer ignored

Opened this issue · 5 comments

shunxing commented

Hi guys

I'm submitting a ...

  • bug report
  • feature request
  • support request

If you're reporting a bug, please provide a minimal demonstration of the problem

https://codesandbox.io/s/xvnxy4lmjq

What is the current behavior?

The red div becomes sticky too early.

What is the expected or desired behavior?

The red div should become sticky only when we scroll to its top

What is your environment?

  • Version: macOS High Sierra
  • Browser: Chrome 67
vcarl commented

Hi @shunxing can you please follow the issue template? It asks for a lot of information that I can't really help you without.

  • 👍1
shunxing commented

@vcarl Hi ! done !

  • 👍1
vcarl commented

Thank you! I'll try to take a peek soon, but I'm very busy with work and life things.

vcarl commented

TY for the excellent bug report! I'm flying today, I'll try to poke this while I'm in the air.

vcarl commented

I should probably capture some of my findings. I did spend a bit of time on this, but this is the first time I've debugged the core of the logic for the library. This seems like a pretty strong assumption of the library, it's going to take a good bit longer before I can find something that I'm positive won't break compatibility.