carbon-design-system/carbon-components-vue

Vue3 File uploader story enhancements

davidnixon opened this issue · 2 comments

davidnixon commented

Detailed description

Thanks @felipebritor for the port to Vue 3! A couple of asks to improve the storybook a bit.

  • Button story has misleading text
    image
    This is also in the Vue 2 story. Could you change the default text for this story to "Add file" to match whats is in React
  • The Vue 2 story has this awkward control to show how the state works.
    image
    Could you add something better to show how to use the states. The React story has "Status for file name (filenameStatus)" control so maybe something like that?
  • The vue 2 story sets the default accept to ".jpg,.png" which makes it easier to test the invalid case.
    image

Additional information

The new port to Vue 3 is really nice!

felipebritor commented

Hi, @davidnixon . Sorry for skipping these details! I'll work on it along the week

davidnixon commented

I think this one is done.