carderne/signal-export

Doc: latest version has no `--overwrite` anymore

maxhbr opened this issue · 6 comments

maxhbr commented

Might be good to fix that:

signal-export/README.md

Line 164 in 6a5f7ef

--overwrite /output \ # this line is obligatory!

carderne commented

Thanks for reporting!
The default behaviour is now just to never overwrite, which feels safer and made for slightly simpler code.

Out of interest: do you think the option should come back, or are you just reporting the out-of-date README?

maxhbr commented

the --overwrite now seems to append or merge the histories.

carderne commented

Yeah that's why I took it away in the first place...

Options:

  1. Just write but don't go out of its way to delete anything (CURRENT BEHAVIOUR)
  2. Explicitly delete delete and recreate the target directory: I guess this is what user's expect, I was just nervous of doing too much destructive stuff
  3. No overwrite option. This is what I briefly had, but the option is actually needed for manual Docker export due to permissions stuff.

I assume you're saying (2) is the way to go?

maxhbr commented

I would have expected 2, yes

carderne commented

Updated to match your expected behaviour here:
8f71f4e

Released in v2.3.7