carderne/signal-export

Docker container chat export failes silently when chat name contains ampersand character.

Closed this issue · 1 comments

Desktop (please complete the following information):

  • OS and version: macOS Ventura 13.2.1 (22D68)
  • Docker version: Docker 4.17.0 (engine 20.10.23)
  • Terminal/shell used: bash 3.2
  • CPU: 2.4 GHz 8-Core Intel Core i9
  • RAM: 32 GB

Describe the bug
Running the Docker image when the chat group name contains an ampersand character ('&') causes the export to silently fail. Chat group names without ampersand characters export as expected.

To reproduce
Steps to reproduce the behavior. Please include the exact commands tried.
Run these commands:

SIGNAL_INPUT='/Users/test/Library/Application Support/Signal'
SIGNAL_OUTPUT='/Users/test/Output/Test'

docker run --rm   -v "$SIGNAL_INPUT:/Signal"   -v "$SIGNAL_OUTPUT:/output"  carderne/sigexport:latest  --overwrite /output --chats='Person 1 & Person 2'

Output is:

Copying and renaming attachments
Creating markdown files
Creating HTML files
Done!

However, no files are created.

Just tried this and not able to reproduce, my group with an & in it gets exported as normal.
I'm on the exact same OS.

If you're able to investigate further and find a fix I'd be happy to merge it.