carl/TipCalculator

[Android Bootcamp] Review my app

Opened this issue · 1 comments

carl commented

Please review, thanks. /cc @nesquena @timothy1ee

👍 nice work Carl. A few notes after checking out the code:

  • Good layout, proper view naming, usage of sp/dp, margin and relative placement rules
  • Good use of string resources for text values
  • Consider experimenting more with the UI (i.e radio buttons instead of buttons)
  • Consider supporting custom tips
  • Should look into using a number (currency) formatter
  • Glad you thought about error handling for invalid or empty input cases
  • See feedback guide for tips on organizing your code and style standards

One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I'm glad you have started that early and I would encourage you to push the projects each week, continue adding your own UI elements and experimenting with optional features that improve the user experience.

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.

Hopefully this has given you a better sense of working with views and the RelativeLayout which is a very powerful layout system, probably one of the best responsive-first layout systems available across web and mobile platforms. The next assignment will build on top of the first concepts introduced here and will also introduce networking, api use, handling remote images and navigating between activities.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or post on the discussion forum on Canvas.

P.S. Be sure to review submitting assignments and please include info like how long the project took, which optional user stories you completed, and any questions you have. Also consider adding a readme with features and screenshots to each project.