carlhuda/janus

Cannot install because molokai color submodule fails to clone

mpeters opened this issue · 3 comments

An install of janus fails because the molokai submodule fails to clone:

Cloning into 'janus/vim/colors/molokai'...
remote: Counting objects: 11, done.
remote: Total 11 (delta 0), reused 0 (delta 0), pack-reused 11
Unpacking objects: 100% (11/11), done.
error: object 0500e432817c4b7493fabaa272dcc8fdad29908c:invalid author/committer line - bad time zone
fatal: Error in object
fatal: unpack-objects failed
Clone of 'https://github.com/vim-scripts/molokai.git' into submodule path 'janus/vim/colors/molokai' failed

Even doing a direct clone of that project by itself fails:

 git clone https://github.com/vim-scripts/molokai.git
Cloning into 'molokai'...
remote: Counting objects: 11, done.
remote: Total 11 (delta 0), reused 0 (delta 0), pack-reused 11
Unpacking objects: 100% (11/11), done.
error: object 0500e432817c4b7493fabaa272dcc8fdad29908c:invalid author/committer line - bad time zone
fatal: Error in object
fatal: unpack-objects failed

I know this isn't directly a janus issue (and molokai project doesn't seem to allow issues to be created), but it does prevent janus from being installed.

I also have this section in my ~/.gitconfig that contributes to the problem:

 [fetch]
         fsckobjects = true

So my git setup is extra strict (based on this advice - https://lists.gnu.org/archive/html/emacs-devel/2016-01/msg01802.html) which makes this clone fail.

So you should add a -c fetch.fsckobjects=false option to the git clone so that it can be worked around during the install no matter what the user's git configuration is.

Well, it seems that adding that option to the top-level git clone doesn't quite work because it doesn't go down to the submodules... Not sure what the solution is there.

I think fetch.fsckobjects = true is way overkill. Not sure if there's a solution to this besides trying to unset it globally at the beginning of rake and reset it at the end.