carloscuesta/gitmoji

Gitmoji's name vs code for 💫

paduszyk opened this issue · 3 comments

paduszyk commented

Discussion

For the "animation" Gitmoji:

{
  "emoji": "💫",
  "entity": "💫",
  "code": ":dizzy:",
  "description": "Add or update animations and transitions.",
  "name": "animation",
  "semver": "patch"
},

there is an inconsitency in its name and code. For the remaining Gitmojis, the name is simply the code with the underscores replaced by dashes and the leading and trailing colons removed.

Is there any specific reason for which this rule is violated for 💫?

Validations

carloscuesta commented

Hey!

I don't recall any reason for it to be different 😅.
The name of the emoji should be the same as the code but without the semicolons, so let's change it back to name: dizzy.

Thanks for finding this, do you want to open a Pull-Request?

  • 👍1
paduszyk commented

OK. I will open the PR ASAP. How would you classify that change? I believe the options are: ♻️, 🚚.

Anyways, maybe you should consider to discard the name field at all? Since it looks like being deterministic...

carloscuesta commented

OK. I will open the PR ASAP. How would you classify that change? I believe the options are: ♻️, 🚚.

✏️ Also works!

Anyways, maybe you should consider to discard the name field at all? Since it looks like being deterministic...

Not sure, some external dependencies, services might be using that field, for now I would focus on fixing this specific issue and we can reevaluate in the future if the name field makes sense at the JSON level.

  • 👍1