Wouldn't it be nice to have an "extra_kwargs" fields in Meta of FilterSet like DRF ?

Question

Wouldn't it be nice to have an "extra_kwargs" fields in Meta of FilterSet like DRF ?

ThalusA opened this issue a year ago · 4 comments

I would love to see something consistent with Django Rest Framework with their extra_kwargs approach. Would you mind adding it to django-filters ? https://www.django-rest-framework.org/api-guide/serializers/#additional-keyword-arguments

It would be nice because it wouldn't make us forced to overwrite the default Filter for a specific field.

Answer 1 · 2023-07-15T08:04:59.000Z

I don't want to expand the API here. Declare the filters explicitly if needed.

Answer 2 · 2023-07-15T10:02:03.000Z

How can I keep the configuration for ModelChoiceFilter for null values and everything else using explicit filters then ? Let's imagine you update your default filters for a specific model, how can I fuse default filters with mine so that my filters won't ever get outdated ? @carltongibson

Answer 3 · 2023-07-15T11:00:03.000Z

See https://django-filter.readthedocs.io/en/main/ref/filterset.html#customise-filter-generation-with-filter-overrides

Answer 4 · 2023-07-15T20:34:16.000Z

But filter overrides works per field class, not by field name ? What if I have two foreign key and I want custom overrides different for both of them ?