carlweis/heroicon-rails

Unclear exception when icon doesn't exist

Closed this issue · 1 comments

clementf commented

Hi @carlweis, first of all, thanks for making this gem!

One thing I noticed, is that if an icon can't be found an unclear exception is raised:

Screenshot 2024-03-04 at 11 03 48

I guess that

heroicon-rails/lib/heroicon/rails/heroicon_helper.rb

Line 58 in ef8f138

rescue StandardError
could be changed for rescue StandardError => e.

carlweis commented

@clementf Thanks for the feedback. I added your change so the error gets reported.

  • ❤️1