carmen-ruby/carmen

"Taiwan, Province of China" to "Taiwan"

Closed this issue · 5 comments

dshack commented

👍

ecbypi commented

Is it a matter of the locale/base/world.yml file being out of date or is the wrong value coming through when using the gem? If the former, the information in locale/base is auto-generated; locale/overlay contains the corrected name. Or is that name incorrect?

thomasdziedzic commented

looking at the source at:
https://github.com/jim/carmen/blob/master/script/update_data.rb#L61

looks like the iso has the wrong value so it's not a matter of regenerating locale/base/world.yml. The wrong value is just coming through with the gem.

Thanks for looking into this!

thomasdziedzic commented

I was able to fix this by creating a file under config/locales in my rails app (since we're also using carmen-rails:

en:
  world:
    tw:
      common_name: Taiwan
      name: Taiwan
      official_name: Taiwan
swcraig commented

I know this is super old.
This is fixed on master. We are working on getting a new release (1.1.0) out soon. Thanks for reporting.