carnager/rofi-pass

Password files with spaces in them are broken

Opened this issue · 0 comments

I just pulled down the latest changes and found that rofi-pass was very broken with the latest version:

rofipassbug

As you might guess, I don't have a bunch of passwords named "-" and one named "@" (nor do I have one named simply "Adventure"). What I do have is a bunch of password files with spaces in their names: several in the format "Thing - subthing", one in the format "user @ service", and another for "Next Adventure".

Upon investigation, it seems that the fix for #191 caused the password file list to be split on spaces instead of newlines, thus rendering any password files with spaces in them inoperable. I've submitted PR #194 to resolve the issue and once again handle passwords with spaces in them as expected, while still using the new find command.