please add missing API documentation items
Opened this issue · 10 comments
This issue is part of the JOSS review.
At https://carnival-data.github.io/carnival/groovydoc/index.html there are still many undocumented items.
Please provide documentation for all items in the API docs.
Done. Updated documentation are available online.
Thank you! However I still see undocumented items.
Hi @KonradHoeffner. If you let us know the areas you feel are under-documented, we can attempt to address them. Thanks.
I mean there are still items that don't have any documentation at all. I have never used Groovy but isn't there some command that lists those items? For example in Rust there is the "missing docs" annotation, so I think this should be possible in other languages as well.
Hi @KonradHoeffner. I am unaware of a way to tag missing docs in Groovy. The tool used to build Groovy documentation is GroovyDoc, which (I assume) is a layer over JavaDoc. I have gone through our source code and attempted to document all the important classes, fields, and methods. The version of Gradle that is currently used for this project creates docs for protected and private elements. Some of these may not have full documentation, but also would not be expected to be used in client code.
Again, if you let us know know which portions of the API are under-documented, we can attempt to address. Thanks.
Unfortunately I don't have the time to manually go through hundreds of documentation items and report which ones exactly are missing but if GroovyDoc is a layer over JavaDoc, maybe it is possible to use Java DocLint.
For example, with JavaDoc, you can use "javadoc -Xdoclint:all ".
Does GroovyDoc have similar functionality?
Public items should be enough, however I am not sure which items are public in the docs as there seems to be no indicator for that.
For example, in https://carnival-data.github.io/carnival/groovydoc/index.html, in
package carnival.core.graph in the interface summary, GraphSchema and GraphValidator are undocumented but that is just one example of many.
Thank you, Konrad. We are almost finished updating the public API documentation.
To view all items in the API documentation:
https://github.com/carnival-data/carnival
=> click link, under External Resources
GroovyDoc API Documentation
https://carnival-data.github.io/carnival/groovydoc/index.html
=> click link, middle top of page
Index
https://carnival-data.github.io/carnival/groovydoc/index.html?index-all.html
Here is what I found:
- apply(org.gradle.api.Project) - Method in CarnivalApplicationPlugin
- AppUtil() - Constructor in AppUtil
- create(java.lang.String) - Method in FieldName
- CodeRefGroup() - Constructor in CodeRefGroup
- conf - Property in CarnivalNeo4jConfiguration.Gremlin.Neo4j
- DataTable.FieldNameExtensions() - Constructor in DataTable.FieldNameExtensions
- DataTable.MetaData() - Constructor in DataTable.MetaData
- DataTableFiles() - Constructor in DataTableFiles
- DataTableVineMethod() - Constructor in DataTableVineMethod
- DataTableVineMethodCall() - Constructor in DataTableVineMethodCall
- DefaultElementConstraint() - Constructor in DefaultElementConstraint
- DefaultGraphValidator() - Constructor in DefaultGraphValidator
- Definition() - Constructor in Definition
- directories - Property in CarnivalNeo4jConfiguration.Gremlin.Neo4j.Conf.Dbms
- EdgeConstraint() - Constructor in EdgeConstraint
- EdgeDomainException() - Constructor in EdgeDomainException
- ExcelUtil.ExcelRow() - Constructor in ExcelUtil.ExcelRow
- ExcelUtil() - Constructor in ExcelUtil
- extractCompoundMultiFeatures(java.util.Map) - Method in FeatureReport
- extractMultiFeatures(java.util.Map) - Method in FeatureReport
- FieldNameExtensions() - Constructor in FieldNameExtensions
- FilesUtil.1 - Class in carnival.util
- FilesUtil.1() - Constructor in FilesUtil.1
- FilesUtil() - Constructor in FilesUtil
- findAllSteps(Set, carnival.util.FeatureSetRecipeStep) - Method in DataSetDescriptor
- findFieldName(java.lang.String, Map<String, String>) - Method in MappedDataTable
- GenericDataTableVineMethod() - Constructor in GenericDataTableVineMethod
- getEdgeConstraints() - Method in DefaultGraphSchema
- getFieldName() - Method in FieldName
- GraphMethod() - Constructor in GraphMethod
- GraphMethodCall() - Constructor in GraphMethodCall
- GraphMethodDynamic() - Constructor in GraphMethodDynamic
- GraphMethodList() - Constructor in GraphMethodList
- GraphMethodProcess() - Constructor in GraphMethodProcess
- GraphValidationError() - Constructor in GraphValidationError
- gremlin - Property in CarnivalNeo4jConfiguration
- GremlinTraitUtilities() - Constructor in GremlinTraitUtilities
- has(org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__, carnival.graph.PropertyDefinition, java.lang.Object) - Method in TinkerpopAnonTraversalExtension
- Identifier() - Constructor in Identifier
- in(org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__, carnival.graph.EdgeDefinition) - Method in TinkerpopAnonTraversalExtension
- isa(org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__, carnival.graph.EdgeDefinition) - Method in TinkerpopAnonTraversalExtension
- IterativeCsvWriter() - Constructor in IterativeCsvWriter
- JsonVineMethod() - Constructor in JsonVineMethod
- JsonVineMethodCall.Meta() - Constructor in JsonVineMethodCall.Meta
- JsonVineMethodCall.Result() - Constructor in JsonVineMethodCall.Result
- JsonVineMethodCall() - Constructor in JsonVineMethodCall
- JsonVineMethodListCall() - Constructor in JsonVineMethodListCall
- LegacyValidator() - Constructor in LegacyValidator
- loadDataFromFile(java.io.File, carnival.util.DataTable) - Method in DataTable
- loadMetaDataFromFile(java.io.File) - Method in DataTable
- Log() - Constructor in Log
- MappedDataTableVineMethod() - Constructor in MappedDataTableVineMethod
- MappedDataTableVineMethodCall() - Constructor in MappedDataTableVineMethodCall
- MAX_VALUE - Field in Base.EX
- MAX_VALUE - Field in Base.PX
- MAX_VALUE - Field in CacheMode
- MAX_VALUE - Field in CodeSystem
- MAX_VALUE - Field in Core.EX
- MAX_VALUE - Field in Core.PX
- MAX_VALUE - Field in Core.VX
- MAX_VALUE - Field in DataSetDescriptorGraph.EX
- MAX_VALUE - Field in DataSetDescriptorGraph.VX
- MAX_VALUE - Field in ExcelUtil.EXCEL
- MAX_VALUE - Field in FeatureReport.DataMode
- MAX_VALUE - Field in FeatureReport.DateWords
- MAX_VALUE - Field in FirstOrLastDateComparator
- MAX_VALUE - Field in SingleValueDateComparator
- MAX_VALUE - Field in SummaryDateComparator
- MAX_VALUE - Field in TestModel.EX
- MAX_VALUE - Field in TestModel.PX
- MAX_VALUE - Field in TestModel.VX
- MetaData(carnival.util.GenericDataTable) - Constructor in GenericDataTable.MetaData
- MIN_VALUE - Field in Base.EX
- MIN_VALUE - Field in Base.PX
- MIN_VALUE - Field in CacheMode
- MIN_VALUE - Field in CodeSystem
- MIN_VALUE - Field in Core.EX
- MIN_VALUE - Field in Core.PX
- MIN_VALUE - Field in Core.VX
- MIN_VALUE - Field in DataSetDescriptorGraph.EX
- MIN_VALUE - Field in DataSetDescriptorGraph.VX
- MIN_VALUE - Field in ExcelUtil.EXCEL
- MIN_VALUE - Field in FeatureReport.DataMode
- MIN_VALUE - Field in FeatureReport.DateWords
- MIN_VALUE - Field in FirstOrLastDateComparator
- MIN_VALUE - Field in SingleValueDateComparator
- MIN_VALUE - Field in SummaryDateComparator
- MIN_VALUE - Field in TestModel.EX
- MIN_VALUE - Field in TestModel.PX
- MIN_VALUE - Field in TestModel.VX
- ModelTransformation() - Constructor in ModelTransformation
- moveKeyBefore(java.lang.String, java.lang.String) - Method in FeatureReport
- neo4j - Property in CarnivalNeo4jConfiguration.Gremlin
- next() - Method in Base.EX
- next() - Method in Base.PX
- next() - Method in CacheMode
- next() - Method in CodeSystem
- next() - Method in Core.EX
- next() - Method in Core.PX
- next() - Method in Core.VX
- next() - Method in DataSetDescriptorGraph.EX
- next() - Method in DataSetDescriptorGraph.VX
- next() - Method in ExcelUtil.EXCEL
- next() - Method in FeatureReport.DataMode
- next() - Method in FeatureReport.DateWords
- next() - Method in FirstOrLastDateComparator
- next() - Method in SingleValueDateComparator
- next() - Method in SummaryDateComparator
- next() - Method in TestModel.EX
- next() - Method in TestModel.PX
- next() - Method in TestModel.VX
- out(org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__, carnival.graph.EdgeDefinition) - Method in TinkerpopAnonTraversalExtension
- previous() - Method in Base.EX
- previous() - Method in Base.PX
- previous() - Method in CacheMode
- previous() - Method in CodeSystem
- previous() - Method in Core.EX
- previous() - Method in Core.PX
- previous() - Method in Core.VX
- previous() - Method in DataSetDescriptorGraph.EX
- previous() - Method in DataSetDescriptorGraph.VX
- previous() - Method in ExcelUtil.EXCEL
- previous() - Method in FeatureReport.DataMode
- previous() - Method in FeatureReport.DateWords
- previous() - Method in FirstOrLastDateComparator
- previous() - Method in SingleValueDateComparator
- previous() - Method in SummaryDateComparator
- previous() - Method in TestModel.EX
- previous() - Method in TestModel.PX
- previous() - Method in TestModel.VX
- PropertyValuesHolder() - Constructor in PropertyValuesHolder
- security - Property in CarnivalNeo4jConfiguration.Gremlin.Neo4j.Conf.Dbms
- setFields(java.util.Map) - Method in DataTable.MetaData
- setFields(java.util.Map) - Method in MappedDataTable.MetaData
- setFields(java.util.Map) - Method in TabularReport.MetaData
- setMeta(java.util.Map) - Method in FeatureReport.MetaData
- setOrderedKeysBooleanCriteria(groovy.lang.Closure) - Method in DataTable
- setOrderKeysByInsertion() - Method in DataTable
- SqlUtils() - Constructor in SqlUtils
- stringHandlingArgs() - Method in DataTable
- StringUtils() - Constructor in StringUtils
- TestModel() - Constructor in TestModel
- TinkerpopAnonTraversalExtension() - Constructor in TinkerpopAnonTraversalExtension
- TinkerpopTraversalExtension() - Constructor in TinkerpopTraversalExtension
- toFieldName(java.lang.String) - Method in DataTable
- toIdValue(java.lang.String) - Method in MappedDataTable
- toString() - Method in FieldName
- toString() - Method in VertexBuilder
- tryParseDate(List, java.lang.String) - Method in FeatureReport
- unrestricted - Property in CarnivalNeo4jConfiguration.Gremlin.Neo4j.Conf.Dbms.Security.Procedures
- unmanaged_extension_classes - Property in CarnivalNeo4jConfiguration.Gremlin.Neo4j.Conf.Dbms
- valueOf(java.lang.String) - Method in Base.EX
- valueOf(java.lang.String) - Method in Base.PX
- valueOf(java.lang.String) - Method in CacheMode
- valueOf(java.lang.String) - Method in CodeSystem
- valueOf(java.lang.String) - Method in Core.EX
- valueOf(java.lang.String) - Method in Core.PX
- valueOf(java.lang.String) - Method in Core.VX
- valueOf(java.lang.String) - Method in DataSetDescriptorGraph.EX
- valueOf(java.lang.String) - Method in DataSetDescriptorGraph.VX
- valueOf(java.lang.String) - Method in ExcelUtil.EXCEL
- valueOf(java.lang.String) - Method in FeatureReport.DataMode
- valueOf(java.lang.String) - Method in FeatureReport.DateWords
- valueOf(java.lang.String) - Method in FirstOrLastDateComparator
- valueOf(java.lang.String) - Method in SingleValueDateComparator
- valueOf(java.lang.String) - Method in SummaryDateComparator
- valueOf(java.lang.String) - Method in TestModel.EX
- valueOf(java.lang.String) - Method in TestModel.PX
- valueOf(java.lang.String) - Method in TestModel.VX
- values() - Method in Base.EX
- values() - Method in Base.PX
- values() - Method in CacheMode
- values() - Method in CodeSystem
- values() - Method in Core.EX
- values() - Method in Core.PX
- values() - Method in Core.VX
- values() - Method in DataSetDescriptorGraph.EX
- values() - Method in DataSetDescriptorGraph.VX
- values() - Method in ExcelUtil.EXCEL
- values() - Method in FeatureReport.DataMode
- values() - Method in FeatureReport.DateWords
- values() - Method in FirstOrLastDateComparator
- values() - Method in SingleValueDateComparator
- values() - Method in SummaryDateComparator
- values() - Method in TestModel.EX
- values() - Method in TestModel.PX
- values() - Method in TestModel.VX
- VertexConstraint() - Constructor in VertexConstraint
- VertexPropertyConstraint() - Constructor in VertexPropertyConstraint
- VineConfiguration.Cache() - Constructor in VineConfiguration.Cache
- VineConfiguration() - Constructor in VineConfiguration
- VineMethod() - Constructor in VineMethod
- visitFile(java.nio.file.Path, java.nio.file.attribute.BasicFileAttributes) - Method in FilesUtil.1
- writeDataTableFiles(java.io.File, java.util.Map) - Method in DataTable
- [ ]
These are labelled "do not use". Are we using them internally? Should we make them private?
- I have no idea where FilesUtil.1 is coming from. It does not appear in the source. Must be an artifact of compilation?
- all methods in TinkerpopAnonTraversalExtension have a @see tag
- MIN_VALUE, MAX_VALUE, valueOf(), values(), previous(), and next() are methods of all enums and should not need commenting
- there are @see references for CarnivalNeo4jConfiguration
- I have no idea where FilesUtil.1 is coming from. It does not appear in the source. Must be an artifact of compilation?
It seems like this is from an anonymous inner class defined here, it should be safe to ignore.