carousell/Orion

potential data race

Closed this issue · 1 comments

jason-xxl commented

Orion/utils/httptripper/httptripper.go

Line 52 in f89dd01

hystrix.Do(req.Method+"-"+req.URL.EscapedPath(),

Ideally, the code should check the error of hystrix.Do and ONLY return data when no error happens. If hystrix.Do returns error, return nil with that error and abandon the resp, err.

ankurs commented

hystrix support has been removed from round tripper!