carstena/game-to-philips-hue

Maxbin is always zero since hue is in range from 0.0f to 1.0f, not 0.0 to 360.0f

Opened this issue · 0 comments

Hi,

I analyzed the source code for image processing and I found the following issues:

  • I think the maxBin for the most frequent hue is not computed in a correct way.
  • BW movies are not handled correctly since the lights are turned off (wheres they can be computed with the correct brightness)
  • if you have more than 3 lights you can't use them in the current version

The following version is fixing theses issue (feel free to merge it with yours):
https://github.com/mixaal/homelights/blob/master/src/main/java/net/mixaal/tools/homelights/image/ImageProcessor.java

Cheers,
Michal