cascadefox/cascade

Download window enhancement

Closed this issue · 7 comments

marclimar commented

Captura
The color is so dark that you can barely see the text.

unseen-ninja commented

mmh, yeah. That's not good. I'll try to look into this but I don't have a windows machine to test the code on, which makes things a little bit more complicated.

I'd assume that you're already running the code with the latest changes? A lot of text-colour issues should have been removed by that, but it might very well be that this isn't affected.
Also: Is your browser itself set to a light or dark theme in the settings; and which theme variant are you using for your system overall?

marclimar commented

Using the latest version and the dark theme for system and browser.

  • 👍1
unseen-ninja commented

Nyeh! I can't even properly reproduce the problem which makes it even harder to fix.
I'll keep this issue open in case someone comes along and is willing to work on this. I'll personally not look further into fixing this myself for now tho. Sorry. :/

  • 😄1
benyaminl commented

@gmkmario are you sure that you're using Dark Theme on Firefox? I mean the firefox theme? Not only by set color on the userChrome.css? Because I can reproduce IF ONLY I use system theme from Firefox with black color on userChrome like this.

Without Dark Theme from Firefox
image

With Dark Theme from Firefox
image

If you haven't turn on the black/dark theme on firefox, try to turn it on, and check does it works or not, if It's not then we can force using

:root {
 color: #fff !important;
}

as the dialog box rely on :root color
example
image

  • 👍3
unseen-ninja commented

Oh, that's a great pointer! That probably explains why I had no way to reproduce this. I didn't bother checking with systemwide Lighttheme on my machine!
Thanks you so much for this. c:

  • 😄1
marclimar commented

I had to force the colors but it works!

benyaminl commented

I had to force the colors but it works!

You have 2 option regarding this, 1st you use your default color from your themes, that mean you must comment the overriding color part and use system color on these lines https://github.com/andreasgrafen/cascade/blob/main/userChrome.css#L39-L64, or you do what I suggest above.

Anyway if it's solved, then you need to close this issue.