casework/CASE-Utility-RDFDiff

verify.py "Match!" emission problematic

ajnelson-nist opened this issue · 3 comments

ajnelson-nist commented

The verifier.py script outputs "Match!" lines for good records. I think this is low-utility information, and possibly counter-productive. If a file is overwhelmingly good records, there are two problems:

  • Any problematic records of small inputs being visually inspected can get lost without filtering.
  • The processing time spent writing "Match!" to screen or log output is significant, and for a large-enough file (say, the 42 MB Plaso sample mft.xml), basically punishes the verification-runner for checking data.

I propose "Match!" not be emitted, except maybe in a "verbose" mode.

jstroud-mitre commented

@ajnelson-nist , this is a great point. I will close this when I update the verifier.py with said functionality. Stay tuned.

jstroud-mitre commented

When you have a moment, please download minify-branch and see if it fixes this issue along with issue-1 and issue-2

ajnelson-nist commented

Menial matter:
TabError: inconsistent use of tabs and spaces in indentation

After correcting that whitespace matter, I think the --verbose flag resolves this Issue. I'll comment on the other issues in their threads.